Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example: cancellation #2525

Merged
merged 4 commits into from
Dec 21, 2018
Merged

example: cancellation #2525

merged 4 commits into from
Dec 21, 2018

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Dec 14, 2018 •
edited
Loading

Fixes #2484

@dfawley dfawley changed the title examples: add cancellation example examples: cancellation Dec 14, 2018
@dfawley dfawley self-assigned this Dec 20, 2018
@menghanl menghanl changed the title examples: cancellation example: cancellation Dec 20, 2018
menghanl
menghanl approved these changes Dec 20, 2018
View reviewed changes
examples/features/cancellation/README.md Outdated
@@ -0,0 +1,11 @@
# Cancellation

This example shows how clients can cancel in-flight RPCs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add something like:

Client cancels the RPC by cancelling the RPC context. Both client and server will receive status with code Cancel.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL?

menghanl
menghanl approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@menghanl menghanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@menghanl menghanl merged commit f286604 into grpc:master Dec 21, 2018
@menghanl menghanl added this to the 1.18 Release milestone Dec 27, 2018
@menghanl menghanl added the Type: Documentation Documentation or examples label Dec 27, 2018
@dfawley dfawley deleted the ex_cancel branch January 8, 2019 19:43
@lock lock bot locked as resolved and limited conversation to collaborators Jul 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees

@dfawley dfawley

Labels
Type: Documentation Documentation or examples
Projects
None yet
Milestone
1.18 Release
Development

Successfully merging this pull request may close these issues.

examples: cancellation
2 participants
@dfawley @menghanl