Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: minor v1 balancer wrapper fixes #2511

Merged
merged 1 commit into from
Jan 30, 2019
Merged

client: minor v1 balancer wrapper fixes #2511

merged 1 commit into from
Jan 30, 2019

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Dec 7, 2018

  • Remove unnecessary checks for failfast
  • Call put reliably
  • Document that done may not be called in the v2 balancer if it returns a SubConn that is not valid (nil or did not come from grpc)
  • Add timeouts to RPCs in TestServerGoAway
  • Minor code cleanups

@dfawley dfawley added this to the 1.18 Release milestone Dec 7, 2018
@dfawley dfawley requested a review from menghanl December 7, 2018 18:38
@dfawley dfawley force-pushed the v1failfast branch 4 times, most recently from 04104ec to 9d25cb3 Compare December 7, 2018 23:44
@menghanl menghanl removed this from the 1.18 Release milestone Jan 17, 2019
@dfawley dfawley added this to the 1.19 Release milestone Jan 30, 2019
@dfawley dfawley merged commit 8e6533e into grpc:master Jan 30, 2019
@dfawley dfawley deleted the v1failfast branch January 30, 2019 18:57
@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees

@menghanl menghanl

Labels
Type: Bug
Projects
None yet
Milestone
1.19 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@dfawley @menghanl