grpclb: filter out grpclb addresses if balancer in use is not grpclb #2509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen when resolved addresses contain grpclb address, but grpclb is not registered.
dfawley
reviewed
Dec 7, 2018
balancer/balancer.go
Outdated
| // balancer map. | ||
| // | ||
| // This function is not thread-safe. And should only be used for testing. | ||
| func UnregisterForTesting(name string) { |
There was a problem hiding this comment.
Can we move this into internal, please? (I.e. store the map itself there.) I want to avoid cluttering our external API with implementation details or testing functions at all costs.
There was a problem hiding this comment.
Added an internal function pointer.
balancer_switching_test.go
Outdated
| r, rcleanup := manual.GenerateAndRegisterManualResolver() | ||
| defer rcleanup() | ||
|
|
||
| numServers := 3 |
There was a problem hiding this comment.
const (or just delete and use the 3 directly on the following line)
dfawley
approved these changes
Dec 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen when resolved addresses contain grpclb address, but grpclb is
not registered.