Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: ensure resolver operations are handled in order #2446

Merged
merged 2 commits into from
Nov 9, 2018
Merged

client: ensure resolver operations are handled in order #2446

merged 2 commits into from
Nov 9, 2018

Conversation

lyuxuan
Copy link
Contributor

@lyuxuan lyuxuan commented Nov 7, 2018 •
edited
Loading

fix #2437

@lyuxuan lyuxuan requested a review from menghanl November 7, 2018 19:47
menghanl
menghanl approved these changes Nov 8, 2018
View reviewed changes
clientconn.go Show resolved Hide resolved
@dfawley dfawley assigned lyuxuan and unassigned menghanl Nov 9, 2018
@lyuxuan lyuxuan merged commit eb55fa5 into grpc:master Nov 9, 2018
@dfawley dfawley changed the title resolverWrapper: remove the watcher goroutine client: ensure resolver operations are handled in order Nov 16, 2018
@dfawley dfawley added this to the 1.17 Release milestone Nov 16, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees

@lyuxuan lyuxuan

Labels
Type: Bug
Projects
None yet
Milestone
1.17 Release
Development

Successfully merging this pull request may close these issues.

Resolver actions may not be handled in order
3 participants
@lyuxuan @menghanl @dfawley