docs: clarify SendMsg/CloseSend usage #2418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
Oct 30, 2018
jeanbza
force-pushed
the
clarify_stream_close_docs
branch
3 times, most recently
from
0358e64 to
d2a2a71
Compare
dfawley
reviewed
Nov 1, 2018
jeanbza
force-pushed
the
clarify_stream_close_docs
branch
from
d2a2a71 to
d71f681
Compare
gopherbot
pushed a commit
to googleapis/google-cloud-go
that referenced
this pull request
Nov 1, 2018
re: https://sponge.corp.google.com/target?id=98425512-e687-4419-a2c4-5296cb727ee1&target=cloud-go-libraries%2Fpresubmit%2Fgo111&searchFor= TestStreamingPullAck has a data race because it relies on calling spc.CloseSend concurrently with spc.Send, which is an unsafe sequence of operations [1]. This CL switches the CloseSend out for a context cancellation, which accomplishes the same thing but is safe to use. It also reduces the time to wait for dupes from 3s to 2s, to speed up the test a bit. 1: grpc-go documentation being amended to describe this, see here: grpc/grpc-go#2418 Change-Id: I254091a664a7d03852568473fa2038751fcc2718 Reviewed-on: https://code-review.googlesource.com/c/34890 Reviewed-by: Eno Compton <[email protected]>
dfawley
approved these changes
Nov 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.