client: block RPCs early until the resolver has returned addresses #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
force-pushed
the
wait_for_resolver
branch
from
ff2d607 to
c53deec
Compare
dfawley
force-pushed
the
wait_for_resolver
branch
from
c53deec to
cceeb34
Compare
menghanl
approved these changes
Nov 6, 2018
clientconn.go
Outdated
| @@ -402,6 +403,10 @@ type ClientConn struct { | |||
| balancerWrapper *ccBalancerWrapper | |||
| retryThrottler atomic.Value | |||
|
|
|||
| resolvedAddrsOnce sync.Once | |||
| resolvedAddrs chan struct{} | |||
There was a problem hiding this comment.
Nit: rename this field? This sounds like a []Address to me.
|
Updated to use a |
menghanl
approved these changes
Nov 8, 2018
clientconn.go
Outdated
| @@ -402,6 +404,8 @@ type ClientConn struct { | |||
| balancerWrapper *ccBalancerWrapper | |||
| retryThrottler atomic.Value | |||
|
|
|||
| resolvedOnce *grpcsync.Event | |||
There was a problem hiding this comment.
The name... This looks like a sync.Once...
How about resolvedEvent?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the initial RPC(s) an opportunity to apply settings from the service config; without this change we would still block, but only after observing the current service config settings.