clientconn: fix race when service config updated while closing #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
changed the title
dfawley
approved these changes
Oct 10, 2018
| @@ -747,6 +747,10 @@ func (cc *ClientConn) handleServiceConfig(js string) error { | |||
| return err | |||
| } | |||
| cc.mu.Lock() | |||
| if cc.conns == nil { | |||
There was a problem hiding this comment.
Comment here why we need this check, please. And please explain why we don't check cc.balancerWrapper instead?
menghanl
force-pushed
the
client_close_resolver_race_panic
branch
from
eb5cfd8 to
3b16c59
Compare
menghanl
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing
ClientConnsetsbalancerWrapperto nil.If service config switches balancer, the new balancer will be notified of the existing addresses.
When these two happens together, there's a chance that a method will be called on the nil
balancerWrapper. This change adds a check to make sure that never happens.fixes #2367