Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check error when calling compressor.Compress #2274

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

JelteF
Copy link
Contributor

@JelteF JelteF commented Aug 24, 2018

Compress can return an error, which was not checked.

@dfawley
Copy link
Member

dfawley commented Aug 24, 2018

Thanks, looks good. Travis isn't running, which usually means you need to rebase your branch with upstream. Yours looks fine, though, so I'm not sure what's wrong. Try adding an empty commit and doing another push?

@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@dfawley
Copy link
Member

dfawley commented Aug 30, 2018

Hi @JelteF, please let me know if you have any issues making travis happy. Also, could you please agree to the CLAs? Thanks!

@dfawley
Copy link
Member

dfawley commented Sep 13, 2018

Hi @JelteF, could you please agree to the CLAs so we can merge this? Thanks!

@JelteF
Copy link
Contributor Author

JelteF commented Sep 14, 2018

I signed it

Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dfawley dfawley added this to the 1.16 Release milestone Sep 14, 2018
@dfawley dfawley merged commit f2aaa9b into grpc:master Sep 14, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Mar 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants