metadata: Fix bug where AppendToOutgoingContext could modify another context's metadata #1930
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1925
For 1-10 append operations, performance is slightly worse using this method, but it is correct and ~3x faster than the old method of copying the whole map.
Before:
After:
The old method for reference:
(Note: I'm also copying
kv...
, because it could be passed asmySlice...
, and I also added a test to demonstrate/catch that.)