put *gzip.Writer back to pool #1441
Conversation
rpc_util.go
Outdated
| @@ -63,6 +63,9 @@ func NewGZIPCompressor() Compressor { | |||
|
|
|||
| func (c *gzipCompressor) Do(w io.Writer, p []byte) error { | |||
| z := c.pool.Get().(*gzip.Writer) | |||
| defer func(){ | |||
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
This reverts commit ae489c4
|
Thanks for finding this and for the fix! It looks like the second commit was done by xuechen.wzm -- if you redo this commit with your other username and |
|
sry for my careless : ( |
|
I'm not sure if this will work. I thought that since there was a commit by another author, it would say you hadn't signed the CLAs. But it's not complaining at the moment. I'll be squashing and merging anyway, and since both authors are you, LGTM and let's hope it actually works. Thanks again for the fix. |
menghanl
added
1.6
Type: Performance
fixes #1439