-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing and wrong license #1422
Conversation
.travis.yml
Outdated
- '! goimports -l . | read' | ||
- '! git ls-files "*.go" | xargs grep -L "\(Copyright [0-9]\{4,\} gRPC authors\)\|DO NOT EDIT" | tee /dev/stderr | read' | ||
- '! gofmt -s -d -l . 2>&1 | tee /dev/stderr | read' | ||
- '! goimports -l . | tee /dev/stderr | read' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2>&1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
.travis.yml
Outdated
@@ -12,8 +12,9 @@ before_install: | |||
- go get -u golang.org/x/tools/cmd/goimports github.com/axw/gocov/gocov github.com/mattn/goveralls golang.org/x/tools/cmd/cover | |||
|
|||
script: | |||
- '! gofmt -s -d -l . 2>&1 | read' | |||
- '! goimports -l . | read' | |||
- '! git ls-files "*.go" | xargs grep -L "\(Copyright [0-9]\{4,\} gRPC authors\)\|DO NOT EDIT" | tee /dev/stderr | read' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2>&1 with grep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
.travis.yml
Outdated
@@ -12,8 +12,9 @@ before_install: | |||
- go get -u golang.org/x/tools/cmd/goimports github.com/axw/gocov/gocov github.com/mattn/goveralls golang.org/x/tools/cmd/cover | |||
|
|||
script: | |||
- '! gofmt -s -d -l . 2>&1 | read' | |||
- '! goimports -l . | read' | |||
- '! git ls-files "*.go" | xargs grep -L "\(Copyright [0-9]\{4,\} gRPC authors\)\|DO NOT EDIT" | tee /dev/stderr | read' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set -o pipefail
...
git ls-files ..... | (! read)
just to be paranoid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
No description provided.