Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing and wrong license #1422

Merged
merged 3 commits into from
Aug 4, 2017
Merged

Fix missing and wrong license #1422

merged 3 commits into from
Aug 4, 2017

Conversation

menghanl
Copy link
Contributor

@menghanl menghanl commented Aug 3, 2017

No description provided.

.travis.yml Outdated
- '! goimports -l . | read'
- '! git ls-files "*.go" | xargs grep -L "\(Copyright [0-9]\{4,\} gRPC authors\)\|DO NOT EDIT" | tee /dev/stderr | read'
- '! gofmt -s -d -l . 2>&1 | tee /dev/stderr | read'
- '! goimports -l . | tee /dev/stderr | read'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2>&1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

.travis.yml Outdated
@@ -12,8 +12,9 @@ before_install:
- go get -u golang.org/x/tools/cmd/goimports github.com/axw/gocov/gocov github.com/mattn/goveralls golang.org/x/tools/cmd/cover

script:
- '! gofmt -s -d -l . 2>&1 | read'
- '! goimports -l . | read'
- '! git ls-files "*.go" | xargs grep -L "\(Copyright [0-9]\{4,\} gRPC authors\)\|DO NOT EDIT" | tee /dev/stderr | read'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2>&1 with grep

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

.travis.yml Outdated
@@ -12,8 +12,9 @@ before_install:
- go get -u golang.org/x/tools/cmd/goimports github.com/axw/gocov/gocov github.com/mattn/goveralls golang.org/x/tools/cmd/cover

script:
- '! gofmt -s -d -l . 2>&1 | read'
- '! goimports -l . | read'
- '! git ls-files "*.go" | xargs grep -L "\(Copyright [0-9]\{4,\} gRPC authors\)\|DO NOT EDIT" | tee /dev/stderr | read'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set -o pipefail
...
git ls-files ..... | (! read)

just to be paranoid

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dfawley dfawley merged commit 963eb48 into grpc:master Aug 4, 2017
@menghanl menghanl added 1.6 Type: Documentation Documentation or examples labels Aug 24, 2017
@dfawley dfawley modified the milestone: 1.6 Release Aug 28, 2017
@menghanl menghanl deleted the license branch October 25, 2017 22:43
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Documentation Documentation or examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants