Decouple transport flow control from application read. #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
reviewed
May 31, 2017
transport/http2_client.go
Outdated
| @@ -845,22 +837,19 @@ func (t *http2Client) handleData(f *http2.DataFrame) { | |||
| t.notifyError(connectionErrorf(true, err, "%v", err)) | |||
| return | |||
| } | |||
| // Decouple connection's flow control form application's read. | |||
There was a problem hiding this comment.
s/form/from
Also, explain a bit more here?
We won't remember what we decoupled when we get used to the new flow control structure.
transport/http2_server.go
Outdated
| // Select the right stream to dispatch. | ||
| s, ok := t.getStream(f) | ||
| if !ok { | ||
| if w := t.fc.onRead(uint32(size)); w > 0 { | ||
| t.controlBuf.put(&windowUpdate{0, w}) | ||
| } | ||
| return | ||
| } | ||
| if size > 0 { | ||
| s.mu.Lock() | ||
| if s.state == streamDone { | ||
| s.mu.Unlock() | ||
| // The stream has been closed. Release the corresponding quota. |
menghanl
approved these changes
Jun 1, 2017
mehrdada
reviewed
Jun 1, 2017
transport/http2_client.go
Outdated
| @@ -845,22 +837,26 @@ func (t *http2Client) handleData(f *http2.DataFrame) { | |||
| t.notifyError(connectionErrorf(true, err, "%v", err)) | |||
| return | |||
| } | |||
| // Decouple connection's flow control from application's read. | |||
| // An update on connection's flow control should not depend on | |||
| // whether user-applicaiton has read the data or not. Such a | |||
There was a problem hiding this comment.
s/user-applicaiton/user application
(ditto for the comment further down)
mehrdada
reviewed
Jun 1, 2017
transport/transport_test.go
Outdated
| return false, nil | ||
| }) | ||
|
|
||
| // Exhaust client's conneciton window. |
menghanl
added
1.4
Type: Performance
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.