Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement EmptyCallOption #1244

Merged
merged 2 commits into from
May 17, 2017
Merged

Implement EmptyCallOption #1244

merged 2 commits into from
May 17, 2017

Conversation

mehrdada
Copy link
Member

Addresses #1223

@mehrdada mehrdada requested a review from dfawley May 15, 2017 18:43
@mehrdada
Copy link
Member Author

PTAL

@mwitkow mwitkow mentioned this pull request May 17, 2017
Closed
mwitkow
mwitkow approved these changes May 17, 2017
View reviewed changes
Copy link
Contributor

@mwitkow mwitkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Just one minor suggestion.

rpc_util.go
type EmptyCallOption struct{}

func (EmptyCallOption) before(*callInfo) error { return nil }
func (EmptyCallOption) after(*callInfo) {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a
var _ CallOption = EmptyCallOption{} to make sure this always satisfies the contract?

@mehrdada mehrdada merged commit 11d93ec into grpc:master May 17, 2017
@mehrdada mehrdada deleted the emptycalloption branch May 17, 2017 21:47
@menghanl menghanl added 1.4 Type: Feature New features or improvements in behavior labels Jun 7, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

@mwitkow mwitkow mwitkow approved these changes

Assignees
No one assigned
Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mehrdada @mwitkow @dfawley @menghanl