Reuse Token for serviceAccount credentials #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamird
reviewed
May 12, 2017
credentials/oauth/oauth.go
Outdated
| func (s serviceAccount) GetRequestMetadata(ctx context.Context, uri ...string) (map[string]string, error) { | ||
| token, err := s.config.TokenSource(ctx).Token() | ||
| func (s *serviceAccount) GetRequestMetadata(ctx context.Context, uri ...string) (map[string]string, error) { | ||
| s.once.Do(func() { s.ts = s.config.TokenSource(ctx) }) |
There was a problem hiding this comment.
This means that ctx will continue to be used even after it has been cancelled by the caller. Doesn't seem bueno.
There was a problem hiding this comment.
Good catch, thanks. I changed it to cache the token internally and fetch a new one when necessary.
MakMukhi
approved these changes
May 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jwt.Config.TokenSource returns a reusable TokenSource; we should re-use it to avoid sending a new request every time we need to use the token.