grpc: make ServerOption panic messages more clear. #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ServerOption panics when fields that have been manually set are subsequently set again. The message verbiage of `X has been set` is unclear since `has been set` without an adverb like `already` does not correctly convey that the fields are set-once and were previously set. At the worst, the original verbiage `X has been set` could imply that the new value would have been acceptable but another error occurred. We discovered this while conducting a code survey for implementing extensible stubs and uniform inbound interception API.
menghanl
approved these changes
May 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServerOption panics when fields that have been manually set are
subsequently set again. The message verbiage of
X has been setisunclear since
has been setwithout an adverb likealreadydoes notcorrectly convey that the fields are set-once and were previously set.
At the worst, the original verbiage
X has been setcould imply thatthe new value would have been acceptable but another error occurred.
We discovered this while conducting a code survey for implementing
extensible stubs and uniform inbound interception API.