Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClientConn: WithTimeout() causes Dial error to be always Canceled #2736

Closed
menghanl opened this issue Apr 3, 2019 · 0 comments · Fixed by #2737
Closed

ClientConn: WithTimeout() causes Dial error to be always Canceled #2736

menghanl opened this issue Apr 3, 2019 · 0 comments · Fixed by #2737
Assignees
@menghanl
Labels
Type: Bug

Comments

@menghanl
Copy link
Contributor

menghanl commented Apr 3, 2019

A solution is rearrange defer functions in DialContext().

#2733 (comment)
@menghanl menghanl self-assigned this Apr 3, 2019
@menghanl menghanl mentioned this issue Apr 3, 2019
Merged
@daviddrysdale daviddrysdale mentioned this issue Apr 3, 2019
Merged
menghanl pushed a commit that referenced this issue Apr 4, 2019
@daviddrysdale @menghanl
Fix DialContext when using a timeout (#2737)
d37bd82 
Fixes #2736
@lock lock bot locked as resolved and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@menghanl menghanl

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ClientConn: fix Dial using grpc.WithTimeout() daviddrysdale/grpc-go
1 participant
@menghanl