Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interop test should use proto3 #1572

Closed
zhangkun83 opened this issue Oct 11, 2017 · 0 comments · Fixed by #1574
Closed

Interop test should use proto3 #1572

zhangkun83 opened this issue Oct 11, 2017 · 0 comments · Fixed by #1574
Assignees
@menghanl
Labels
P1 Type: Testing

Comments

@zhangkun83
Copy link

grpc-go is using proto2 in the interop test, while Java and C++ are both using proto3. Mixing proto2 and proto3 has wire compatibility issues and should be avoided. Go should switch to proto3 in the interop test.
zhangkun83 added a commit to zhangkun83/grpc-java that referenced this issue Oct 11, 2017
@zhangkun83
interop-test: disable message size check in interop-test client.
b2aa91d 
The check fails in Java-Go interop test because of
grpc/grpc-go#1572

Resolves grpc#3562
zhangkun83 added a commit to zhangkun83/grpc-java that referenced this issue Oct 11, 2017
@zhangkun83
interop-test: disable message size check in interop-test client.
e266299 
The check fails in Java-Go interop test because of
grpc/grpc-go#1572

Resolves grpc#3562
@zhangkun83 zhangkun83 mentioned this issue Oct 11, 2017
Merged
@menghanl menghanl mentioned this issue Oct 11, 2017
Merged
@adelez adelez mentioned this issue Oct 12, 2017
Merged
@dfawley dfawley added the P1 label Oct 12, 2017
zhangkun83 added a commit to grpc/grpc-java that referenced this issue Oct 13, 2017
@zhangkun83
interop-test: disable message size check in interop-test client. (#3569)
9c817e5 
The check fails in Java-Go interop test because of
grpc/grpc-go#1572

This is also needed for the internal gRPC-GFE test.

Resolves #3562
@adelez adelez mentioned this issue Oct 16, 2017
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2018
fixmebot bot referenced this issue in aomsw13/develop_test Apr 12, 2021
@testfixme
Update readme.md
70b8890
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@menghanl menghanl

Labels
P1 Type: Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use proto3 in interop tests and end2end tests menghanl/grpc-go
3 participants
@menghanl @zhangkun83 @dfawley