Skip to content

Fix System.CommandLine 2.0.0 Uri parsing in GrpcClient benchmark app #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesNK merged 1 commit into from
Mar 9, 2026
Merged

Fix System.CommandLine 2.0.0 Uri parsing in GrpcClient benchmark app #2695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion perf/benchmarkapps/GrpcClient/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,21 @@ class Program

public static async Task<int> Main(string[] args)
{
var urlOption = new Option<Uri>("--url", ["-u"]) { Description = "The server url to request", Required = true };
var urlOption = new Option<Uri>("--url", ["-u"])
{
Description = "The server url to request",
Required = true,
CustomParser = result =>
{
var token = result.Tokens.SingleOrDefault();
if (token is null || !Uri.TryCreate(token.Value, UriKind.Absolute, out var uri))
{
result.AddError("The --url option requires a valid absolute URI.");
return null;
}
return uri;
}
};
var udsFileNameOption = new Option<string>("--udsFileName") { Description = "The Unix Domain Socket file name" };
var namedPipeNameOption = new Option<string>("--namedPipeName") { Description = "The Named Pipe name" };
var connectionsOption = new Option<int>("--connections", ["-c"]) { DefaultValueFactory = (r) => 1, Description = "Total number of connections to keep open" };
Expand Down