Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interceptor support #45

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Add interceptor support #45

merged 1 commit into from
Dec 1, 2023

Conversation

artificial-aidan
Copy link

@artificial-aidan artificial-aidan commented Nov 29, 2023 •
edited
Loading

Helps fix #37

@artificial-aidan
Add interceptor support
81e0a4e 
Signed-off-by: Aidan Jensen <[email protected]>
@artificial-aidan artificial-aidan mentioned this pull request Nov 29, 2023
Closed
@ViridianForge ViridianForge self-assigned this Nov 30, 2023
ViridianForge
ViridianForge reviewed Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@ViridianForge ViridianForge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question - and can you re-target the PR against the develop branch?

requirements-dev.txt Show resolved Hide resolved
@artificial-aidan artificial-aidan changed the base branch from master to develop November 30, 2023 06:31
ViridianForge
ViridianForge approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@ViridianForge ViridianForge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@ViridianForge ViridianForge merged commit 48ae253 into grpc-requests:develop Dec 1, 2023
6 checks passed
@imrimt
Copy link

imrimt commented Oct 29, 2024

I just ran into this using the metadata keyword. Looks like the docs still references this mechanism even though it doesn't seem to work. Can we get the updated example of how to use the interceptors for authorization like this?

@ViridianForge ViridianForge mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViridianForge ViridianForge ViridianForge approved these changes

Assignees

@ViridianForge ViridianForge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

metadata keyword argument not respected by get_by_endpoint()
3 participants
@artificial-aidan @imrimt @ViridianForge