Add semantic version from git tag #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanb
commented
Oct 23, 2023
| @@ -214,6 +214,8 @@ func buildCredentials(skipVerify bool, caCerts, clientCert, clientKey, serverNam | |||
| return credentials.NewTLS(&cfg), nil | |||
| } | |||
|
|
|||
| var versionTag = "" // set from git tag via ldflags during build | |||
There was a problem hiding this comment.
We can also default to eg. "development":
Suggested change
| var versionTag = "" // set from git tag via ldflags during build | |
| var versionTag = "development" // set from git tag via ldflags during build |
and remove the condition lower to keep code simpler and provide consistent output structure.
There was a problem hiding this comment.
Yeah sounds good. I initially deemed tag is not so useful and anyone who needs can derive it from commit ID.
There was a problem hiding this comment.
"Sounds good" as in omiting the tag if not set via ldflags (as currently implemented) or showing the "development" in such cases (as suggested as an option in this comment thread)?
stefanb
force-pushed
the
add-version-from-git-tag
branch
from
6dc82a8
to
d356a18
Compare
ahmetb
approved these changes
Oct 26, 2023
|
Binaries of the recent v0.4.22 release show the version from tag as: |
|
Awesome, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves upon #146 to include the semantic version number from git tag.