Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc for opentracing support #987

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Add doc for opentracing support #987

merged 1 commit into from
Aug 9, 2019

Conversation

vthiery
Copy link
Contributor

@vthiery vthiery commented Aug 9, 2019

Mention the fact that the client must be initialized with an opentracing interceptor to allow the propagation of spans through the gateway.

I originally followed the doc but completely forgot about adding this interceptor to the gRPC client. Thought it might help others save time.
Please let me know if this isn't accurate enough (or wrong!).

Mention the fact that the client must be initialized with an opentracing interceptor to allow the propagation of spans through the gateway.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@codecov-io
Copy link

Codecov Report

Merging #987 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #987   +/-   ##
=======================================
  Coverage   53.43%   53.43%           
=======================================
  Files          40       40           
  Lines        4027     4027           
=======================================
  Hits         2152     2152           
  Misses       1676     1676           
  Partials      199      199

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 643a3cf...d0472c0. Read the comment docs.

@vthiery
Copy link
Contributor Author

vthiery commented Aug 9, 2019

@googlebot I signed it!

@vthiery
Copy link
Contributor Author

vthiery commented Aug 9, 2019

Having more doc on this topic was actually suggested here

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks for this!

@johanbrandhorst
Copy link
Collaborator

Not sure what's up with Googlebot, @achew22?

@vthiery
Copy link
Contributor Author

vthiery commented Aug 9, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Aug 9, 2019
@vthiery
Copy link
Contributor Author

vthiery commented Aug 9, 2019

Not sure what's up with Googlebot, @achew22?

I signed the CLA logged with one Google account, but the commit was made with another one. All good now

@johanbrandhorst johanbrandhorst merged commit b6e6efb into grpc-ecosystem:master Aug 9, 2019
@vthiery vthiery deleted the add-doc-for-opentracing-support branch August 9, 2019 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants