Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EOF on send #962

Merged
merged 3 commits into from
Jun 28, 2019
Merged

EOF on send #962

merged 3 commits into from
Jun 28, 2019

Conversation

gustavocovas
Copy link
Contributor

As we suggested on #961, add a verification for io.EOF on the generated code template, along with an integration test

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@gustavocovas
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just a small question

examples/integration/integration_test.go Outdated Show resolved Hide resolved
@johanbrandhorst
Copy link
Collaborator

Looks like you need to regenerate the files too, see the contribution guidelines document.

@johanbrandhorst
Copy link
Collaborator

johanbrandhorst commented Jun 28, 2019

The CLA issue can be manually fixed if we can get approval from @jonasarilho your co-author to merge this. A comment in this PR suffices.

@codecov-io
Copy link

Codecov Report

Merging #962 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #962      +/-   ##
==========================================
- Coverage   53.26%   53.22%   -0.04%     
==========================================
  Files          40       40              
  Lines        4001     4004       +3     
==========================================
  Hits         2131     2131              
- Misses       1672     1675       +3     
  Partials      198      198
Impacted Files Coverage Δ
protoc-gen-grpc-gateway/gengateway/template.go 67.03% <ø> (ø) ⬆️
examples/server/a_bit_of_everything.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d29f14...c0f90ab. Read the comment docs.

@jonasarilho
Copy link

I approve these changes.

@johanbrandhorst
Copy link
Collaborator

@achew22 @ivucica could one of you manually approve the CLA please.

@achew22 achew22 added cla: yes and removed cla: no labels Jun 28, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@johanbrandhorst johanbrandhorst merged commit 21fa8c3 into grpc-ecosystem:master Jun 28, 2019
@johanbrandhorst
Copy link
Collaborator

Thanks a lot for the contribution!

@gustavocovas gustavocovas deleted the bug/eof-on-send branch June 28, 2019 16:15
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
* Add integration test for grpc-ecosystem#961

Co-authored-by: Jonas Arilho <[email protected]>

* Add verification for io.EOF after stream.Send() on generated code template (grpc-ecosystem#961)

Co-authored-by: Jonas Arilho <[email protected]>

* Add more values on testABEBulkCreateWithError, run go mod tidy

Fixes grpc-ecosystem#961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants