Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README file #950

Merged
merged 1 commit into from
Jun 16, 2019

Conversation

charleswhchan
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 16, 2019

Codecov Report

Merging #950 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #950      +/-   ##
==========================================
- Coverage   53.23%   53.06%   -0.18%     
==========================================
  Files          40       40              
  Lines        3999     3969      -30     
==========================================
- Hits         2129     2106      -23     
+ Misses       1672     1667       -5     
+ Partials      198      196       -2
Impacted Files Coverage Δ
runtime/mux.go 53.22% <0%> (-2.16%) ⬇️
protoc-gen-grpc-gateway/gengateway/template.go 65.51% <0%> (-1.52%) ⬇️
runtime/pattern.go 91.42% <0%> (+1.04%) ⬆️
protoc-gen-grpc-gateway/descriptor/registry.go 59.82% <0%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77cc68...2e30705. Read the comment docs.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! Just one small point.

README.md Outdated Show resolved Hide resolved
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@johanbrandhorst johanbrandhorst merged commit e7ba6a4 into grpc-ecosystem:master Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants