Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "protoc-gen-swagger: check typeIndex when typeName is Method" #945

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

johanbrandhorst
Copy link
Collaborator

@johanbrandhorst johanbrandhorst commented Jun 13, 2019

This reverts the changes introduced in #833. It caused
a regression in the swagger generator allow_merge behaviour.

Fixes #923

This reverts the changes introduced in #833. It caused
a regression in the swagger generator allow_merge behaviour.

Fixes #923
@codecov-io
Copy link

Codecov Report

Merging #945 into master will decrease coverage by 0.73%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #945      +/-   ##
==========================================
- Coverage   53.79%   53.06%   -0.74%     
==========================================
  Files          40       40              
  Lines        3969     3969              
==========================================
- Hits         2135     2106      -29     
- Misses       1638     1667      +29     
  Partials      196      196
Impacted Files Coverage Δ
protoc-gen-swagger/genswagger/template.go 53.51% <0%> (-2.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6f18d3...8f94472. Read the comment docs.

@johanbrandhorst
Copy link
Collaborator Author

@prestonvanloon @co3k could you try this binary and confirm it fixes the issue before I merge this?
protoc-gen-swagger-linux-x84_86.zip

@prestonvanloon
Copy link
Contributor

prestonvanloon commented Jun 13, 2019

@joelclouddistrict so I merged this branch into my branch for #944 and I still get the same behavior where comments where not applied to the operations. I didn't try the linked binary, but I would have expected the same behavior from the bazel toolchain.

Edit: I didn't merge it (oops). Yes it works prestonvanloon@92b800e

@johanbrandhorst johanbrandhorst merged commit 14c2471 into master Jun 13, 2019
@johanbrandhorst johanbrandhorst deleted the revert-typeindex-fix branch June 13, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merging swagger specs fails to use rpc comments (again)
4 participants