Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better grpc error strings #94

Merged
merged 1 commit into from
Jan 27, 2016
Merged

Better grpc error strings #94

merged 1 commit into from
Jan 27, 2016

Conversation

floridoo
Copy link

See issue #87

@yugui
Copy link
Member

yugui commented Jan 26, 2016

test failing.

@floridoo
Copy link
Author

but unrelated to the pull request, it fails on the master branch too
Sorry, my bad. You are right.

@sadlil
Copy link

sadlil commented Jan 26, 2016

Fails as json.Unmarshal can't unmarshal int into string here. @floridoo
errors_test.go

@sadlil sadlil mentioned this pull request Jan 26, 2016
Closed
@floridoo
Copy link
Author

Passing now.

Thanks @sadlil

@yugui
Copy link
Member

yugui commented Jan 27, 2016

LGTM

yugui added a commit that referenced this pull request Jan 27, 2016
@yugui
Merge pull request #94 from floridoo/master
820fef9 
Better grpc error strings
@yugui yugui merged commit 820fef9 into grpc-ecosystem:master Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@floridoo @yugui @sadlil