Fix make test on MacOS #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make test errors out on MacOS because it uses bsd find instead of gnu find which is standard in most Linux distributions. The fix just provides an explicit folder . which bsd find requires but gnu find has as default.
Codecov Report
@@ Coverage Diff @@
## master #935 +/- ##
=======================================
Coverage 53.84% 53.84%
=======================================
Files 40 40
Lines 3965 3965
=======================================
Hits 2135 2135
Misses 1634 1634
Partials 196 196Continue to review full report at Codecov.
|
johanbrandhorst
approved these changes
May 14, 2019
|
@emilaasa welcome to the team! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make testerrors out on MacOS because it uses bsd find instead of gnufind which is standard in most Linux distributions. The fix just
provides an explicit folder . which bsd find requires but gnu find has
as default.
Verifying should be as simple as running make test on a clean repo with any version of gnu
find(i.e running on linux).