-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: disable IOReaderFactory for streaming requests #896
bugfix: disable IOReaderFactory for streaming requests #896
Conversation
46fefbe
to
5f06474
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix! Just a small comment.
Could you try building the grpc-gateway generator off this branch and see if it fixes tmc/grpc-websocket-proxy#14 for you? |
An IOReaderFactory was being used to wrap request body for client/bidi streaming requests. This was causing the requests to be fully buffered before being sent to the grpc server, thereby breaking streaming. This commit changes that to directly use request body.
5f06474
to
5bf89d8
Compare
Codecov Report
@@ Coverage Diff @@
## master #896 +/- ##
=======================================
Coverage 53.69% 53.69%
=======================================
Files 39 39
Lines 3926 3926
=======================================
Hits 2108 2108
Misses 1621 1621
Partials 197 197
Continue to review full report at Codecov.
|
Yes, my websocket client is working again. |
Thank you so much for this contribution! |
An IOReaderFactory was being used to wrap request body for client/bidi streaming requests. This was causing the requests to be fully buffered before being sent to the grpc server, thereby breaking streaming. This commit changes that to directly use request body. Fixes grpc-ecosystem#894
An IOReaderFactory was being used to wrap request body for client/bidi streaming
requests. This was causing the requests to be fully buffered before being sent
to the grpc server, thereby breaking streaming. This commit changes that to
directly use request body.
Fixes #894