Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to go modules #870

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Switch to go modules #870

merged 1 commit into from
Feb 19, 2019

Conversation

johanbrandhorst
Copy link
Collaborator

Fixes #755

@achew22 Do I need to do anything more WRT bazel here? I've just removed WORKSPACE since I assume it's superfluous with the module definitions.

@johanbrandhorst
Copy link
Collaborator Author

Obviously still WIP, but I wanted to get the ball rolling on this

@achew22
Copy link
Collaborator

achew22 commented Feb 19, 2019

I think reverting the delete of the WORKSPACE is all you should need to do to get it working in Bazel. Once you merge this I'll do a follow up to upgrade to the latest rules_go which has proper support for go modules and clean it up in there a bit.

@johanbrandhorst johanbrandhorst force-pushed the switch-go-modules branch 4 times, most recently from ce82fae to 1d3888e Compare February 19, 2019 11:12
@johanbrandhorst johanbrandhorst marked this pull request as ready for review February 19, 2019 11:24
@johanbrandhorst
Copy link
Collaborator Author

I think this should be ready for a review @achew22.

The node tests are still using a vendor folder instead of a GOPATH but that's okay I think.

The generate test now includes running go mod tidy afterwards because otherwise it seems to make the resty dependency indirect. I don't understand how that all interacts.

@codecov-io
Copy link

Codecov Report

Merging #870 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #870   +/-   ##
=======================================
  Coverage   52.99%   52.99%           
=======================================
  Files          39       39           
  Lines        3910     3910           
=======================================
  Hits         2072     2072           
  Misses       1642     1642           
  Partials      196      196

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ada3454...8c077d0. Read the comment docs.

@achew22 achew22 merged commit 6806a84 into master Feb 19, 2019
@johanbrandhorst johanbrandhorst deleted the switch-go-modules branch February 19, 2019 16:02
@johanbrandhorst
Copy link
Collaborator Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants