-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better protbuf version pin #844
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Codecov Report
@@ Coverage Diff @@
## master #844 +/- ##
=======================================
Coverage 50.46% 50.46%
=======================================
Files 39 39
Lines 3761 3761
=======================================
Hits 1898 1898
Misses 1681 1681
Partials 182 182 Continue to review full report at Codecov.
|
I signed it! |
CLAs look good, thanks! |
Hi @gen1us2k. This is unfortunately one of those it's not that simple cases. We're very keen to keep the versions pinned between our Bazel dependencies and our The longer term solution to this is #755. If you are interested in implementing that, please do, but this PR as it is is incomplete. |
Closing this due to inactivity, please open another one if you wish to continue this work. |
No description provided.