Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gengateway: allow opting out patch feature #840

Merged
merged 1 commit into from
Jan 8, 2019
Merged

gengateway: allow opting out patch feature #840

merged 1 commit into from
Jan 8, 2019

Conversation

glerchundi
Copy link
Contributor

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny nitpick, looks good overall!

protoc-gen-grpc-gateway/main.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Jan 7, 2019

Codecov Report

Merging #840 into master will increase coverage by 0.23%.
The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #840      +/-   ##
==========================================
+ Coverage   50.22%   50.46%   +0.23%     
==========================================
  Files          39       39              
  Lines        3755     3761       +6     
==========================================
+ Hits         1886     1898      +12     
+ Misses       1687     1681       -6     
  Partials      182      182
Impacted Files Coverage Δ
protoc-gen-grpc-gateway/gengateway/generator.go 39% <33.33%> (+0.22%) ⬆️
protoc-gen-grpc-gateway/gengateway/template.go 64.28% <80%> (+10.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6d3ad2...3c839ab. Read the comment docs.

@glerchundi
Copy link
Contributor Author

PTAL @johanbrandhorst, it seems like a bazel test is not passing but i think it's not something related to this change.

@achew22
Copy link
Collaborator

achew22 commented Jan 7, 2019

@glerchundi, Yep that is on me. Lemme send a PR to fix Bazel. Sorry about that.

@glerchundi
Copy link
Contributor Author

glerchundi commented Jan 7, 2019 via email

@achew22
Copy link
Collaborator

achew22 commented Jan 7, 2019

#841 should fix that. If you could please rebase it would be hugely appreciated. Thanks!

@glerchundi
Copy link
Contributor Author

@achew22 rebased, lets see :)

Thanks!

@glerchundi
Copy link
Contributor Author

Green! thanks @achew22.

@johanbrandhorst johanbrandhorst merged commit 96cb2e2 into grpc-ecosystem:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants