Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #782 Cannot return HTTP header using "Grpc-Metadata-" prefix #784

Conversation

joelclouddistrict
Copy link
Contributor

@joelclouddistrict joelclouddistrict commented Oct 17, 2018

Fixes #728, supercedes #783

@codecov-io
Copy link

Codecov Report

Merging #784 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #784      +/-   ##
==========================================
+ Coverage   53.37%   53.39%   +0.01%     
==========================================
  Files          30       30              
  Lines        3361     3362       +1     
==========================================
+ Hits         1794     1795       +1     
  Misses       1392     1392              
  Partials      175      175
Impacted Files Coverage Δ
runtime/mux.go 44.16% <100%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61203f4...77f1f0c. Read the comment docs.

@joelclouddistrict
Copy link
Contributor Author

Can this be merged?

@johanbrandhorst
Copy link
Collaborator

Yes, great, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants