Lock versions to tags where possible #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using an exact revisions in `Gopkg.toml` prevents `dep` from detecting equivalence between constraints in the case where one dependency depends on, for example, golang/protobuf v1.1.0 and another depends on the revision that is tagged with that version. Using tagged versions should help with this.
|
This change does not introduce any version changes, it just relaxes the versions that downstream dependants can use to |
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
=======================================
Coverage 56.16% 56.16%
=======================================
Files 30 30
Lines 3112 3112
=======================================
Hits 1748 1748
Misses 1193 1193
Partials 171 171Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an exact revisions in
Gopkg.tomlpreventsdepfrom detecting equivalence between constraints in the case where one dependency depends on, for example, golang/protobuf v1.1.0 and another depends on the revision that is tagged with that version. Using tagged versions should help with this.