Fix naming convention of JSON Schema didn't matched with the spec #719
+165
−164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #719 +/- ##
=======================================
Coverage 56.16% 56.16%
=======================================
Files 30 30
Lines 3112 3112
=======================================
Hits 1748 1748
Misses 1193 1193
Partials 171 171
Continue to review full report at Codecov.
|
|
Doh! |
|
Could you just include a link to the spec in the commit message and description as well? Good for future reference. |
johanbrandhorst
approved these changes
Aug 7, 2018
please see also the schemaObject definition of OpenAPI v2 spec: https://github.com/OAI/OpenAPI-Specification/blob/3.0.0/versions/2.0.md#schemaObject
co3k
force-pushed
the
fix-invalid-swagger-property-name
branch
from
59f6c06
to
2183528
Compare
|
Oops. I did not realize @johanbrandhorst requested a change. I only saw the change was approved. sigh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. min_length should be converted as minLength in Swagger spec, but it wasn't.
please see also the schemaObject definition of OpenAPI v2 spec
This bug is introduced by #687 changes.