Updated doc and comments to reflect Permanent HTTP header keys prefixing #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prefixing gRPC metadata context when dealing with Permanent HTTP header keys
Codecov Report
@@ Coverage Diff @@
## master #691 +/- ##
=======================================
Coverage 56.47% 56.47%
=======================================
Files 30 30
Lines 3005 3005
=======================================
Hits 1697 1697
Misses 1145 1145
Partials 163 163
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the grpc-gateway the docs seemed to suggest that if I added a custom header to a HTTP request (using
Grpc-Metadata-prefix), it would be passed to the gRPC metadata context asgrpcgateway-some-header-key.It is just passed as
some-header-key, only permanent headers are prefixed.