fix: add missing return statements in error handler paths#6561
Merged
johanbrandhorst merged 1 commit intogrpc-ecosystem:mainfrom Apr 2, 2026
Merged
Conversation
Collaborator
|
Looks like tests are failing under Bazel, for some reason: |
3f1cb81 to
98c8ea7
Compare
Contributor
Author
|
fixed |
Collaborator
|
Thanks for your contribution! |
This was referenced Apr 23, 2026
fix(deps): vuln minor upgrades — 11 packages (minor: 7 · patch: 4) [server]
DataDog/temporalio-ui#27
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs
N/A
Have you read the Contributing Guidelines?
Yes
Brief description of what is fixed or changed
Add missing return after handling error to avoid modifying response headers after response is sent which causes error
http: superfluous response.WriteHeader.Other comments
This issue only happens with non-legacy unescape modes. The decision of whether
%should be actually escaped or not depends on the escape mode & is not fixed/implemented in this PR.