Skip to content

fix: allow proto3 optional fields in path parameters #6416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johanbrandhorst merged 2 commits into from
Mar 4, 2026
Merged

fix: allow proto3 optional fields in path parameters #6416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e866b7
fix: allow proto3 optional fields in path parameters
susanachl Feb 27, 2026
bb87d25
Output after running regenerate command
susanachl Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
426 changes: 426 additions & 0 deletions examples/internal/clients/abe/api/swagger.yaml
View file
Open in desktop

Large diffs are not rendered by default.

389 changes: 389 additions & 0 deletions examples/internal/clients/abe/api_a_bit_of_everything.go
View file
Open in desktop

Large diffs are not rendered by default.

905 changes: 455 additions & 450 deletions examples/internal/proto/examplepb/a_bit_of_everything.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

92 changes: 92 additions & 0 deletions examples/internal/proto/examplepb/a_bit_of_everything.pb.gw.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion examples/internal/proto/examplepb/a_bit_of_everything.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,13 @@ service ABitOfEverythingService {
option (google.api.http) = {get: "/v1/example/a_bit_of_everything/{uuid}"};
}
rpc Custom(ABitOfEverything) returns (ABitOfEverything) {
option (google.api.http) = {post: "/v1/example/a_bit_of_everything/{uuid}:custom"};
option (google.api.http) = {
post: "/v1/example/a_bit_of_everything/{uuid}:custom"
additional_bindings: {
// Testing proto3 optional field
get: "/v1/example/a_bit_of_everything/custom/{optional_string_value}"
}
};
}
rpc DoubleColon(ABitOfEverything) returns (ABitOfEverything) {
option (google.api.http) = {post: "/v1/example/a_bit_of_everything/{uuid}:custom:custom"};
Expand Down
Loading
Loading