fix: use proto.Merge to avoid copylocks with use_opaque_api=true#6383
Merged
johanbrandhorst merged 1 commit intogrpc-ecosystem:mainfrom Feb 19, 2026
Merged
Conversation
When use_opaque_api=true, the generated protoReq = bodyData copies protoimpl.MessageState (which contains sync.Mutex), triggering go vet copylocks. Replace with proto.Merge(&protoReq, &bodyData). Fixes grpc-ecosystem#6380
johanbrandhorst
approved these changes
Feb 19, 2026
Collaborator
johanbrandhorst
left a comment
johanbrandhorst
left a comment
There was a problem hiding this comment.
LGTM, thank you!
This was referenced Apr 23, 2026
fix(deps): vuln minor upgrades — 11 packages (minor: 7 · patch: 4) [server]
DataDog/temporalio-ui#27
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
use_opaque_api=true, the generatedprotoReq = bodyDatacopiesprotoimpl.MessageState(which containssync.Mutex), triggeringgo vet copylocks. Replace withproto.Merge(&protoReq, &bodyData).Changes
protoc-gen-grpc-gateway/internal/gengateway/template.go: Replace valueassignment with
proto.Mergeto avoid copyingprotoimpl.MessageState(which embeds
sync.Mutex)*.pb.gw.goexamplesReferences to other Issues or PRs