fix compile errors caused by protobuf finally merging their dev branch to master #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 1, 2018
Closed
jhump
force-pushed
the
jh/fix-for-new-protobuf
branch
from
e47c1ee
to
9d75cb8
Compare
jhump
force-pushed
the
jh/fix-for-new-protobuf
branch
from
9d75cb8
to
378ad71
Compare
Codecov Report
@@ Coverage Diff @@
## master #636 +/- ##
=======================================
Coverage 58.88% 58.88%
=======================================
Files 30 30
Lines 2853 2853
=======================================
Hits 1680 1680
Misses 1010 1010
Partials 163 163Continue to review full report at Codecov.
|
achew22
approved these changes
May 1, 2018
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build breakages caused by upstream: golang/protobuf#591
Unkeyed struct literals for proto messages are now explicitly prevent w/ extra fields in the message thanks to new
XXX_NoUnkeyedLiteralfields generated in every message. (Even w/out that field, the newXXX_unrecognizedandXXX_sizecachealso effectively break any usage of unkeyed struct literals.)There were also some
reflect.DeepEqualusages to compare protos, which can be be incorrect (mainly due toXXX_sizecache).Finally, one of the test configurations verifies that the generated code is up-to-date. So I re-generated the impact
*.pb.gofiles with latestprotoc-gen-go.