fix(gengateway): use pointer for bodyData in OpaqueAPI PATCH requests#6246
Merged
johanbrandhorst merged 4 commits intogrpc-ecosystem:mainfrom Jan 18, 2026
Merged
Conversation
When generating code for the OpaqueAPI with a PATCH request that includes a FieldMask, the generated code incorrectly declared `bodyData` as a value type. This caused a compilation error when passing it to the `SetXXX` method, which expects a pointer for message types. This change updates the templates to declare `bodyData` as a pointer and decode directly into it. Additionally, extended `examples/internal/proto/examplepb/opaque.proto` with an `OpaqueUpdateProduct` method to serve as a test and reproduction case for this scenario.
johanbrandhorst
requested changes
Jan 16, 2026
Collaborator
|
Thank you! |
This was referenced Apr 23, 2026
fix(deps): vuln minor upgrades — 11 packages (minor: 7 · patch: 4) [server]
DataDog/temporalio-ui#27
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating code for the OpaqueAPI with a PATCH request that includes a FieldMask, the generated code incorrectly declared
bodyDataas a value type. This caused a compilation error when passing it to theSetXXXmethod, which expects a pointer for message types.This change updates the templates to declare
bodyDataas a pointer and decode directly into it.Additionally, extended
examples/internal/proto/examplepb/opaque.protowith anOpaqueUpdateProductmethod to serve as a test and reproduction case for this scenario.Fixes: #6234