fix(gengateway): correct body field decoding in opaque API mode#6197
Merged
johanbrandhorst merged 1 commit intogrpc-ecosystem:mainfrom Dec 26, 2025
Merged
Conversation
When `use_opaque_api` is enabled with a body field mapping (e.g., `body: "field_name"`), the generated code was incorrectly decoding the HTTP request body as the full request message type instead of the specific field's message type. This fix: - Adds GetBodyFieldType() helper to determine the body field's type - Updates template to decode into the field type and pass it directly to the setter method Fixes grpc-ecosystem#6189
johanbrandhorst
approved these changes
Dec 26, 2025
Collaborator
johanbrandhorst
left a comment
There was a problem hiding this comment.
Thanks for the quick fix! The bazel error seems unrelated, I expect it will go away.
This was referenced Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs
Fixes #6189
Have you read the Contributing Guidelines?
Yes
Brief description of what is fixed or changed
When
use_opaque_apiis enabled with a body field mapping (e.g.,body: "field_name"), the generated code was incorrectly decoding the HTTP request body as the full request message type instead of the specific field's message type.This fix:
Other comments
I added
OpaqueCreateProductandOpaqueCreateProductFieldtoopaque.prototo act as a test case.Generated code shows the difference. Note
var bodyData OpaqueCreateProductRequestvsbodyData := &OpaqueProduct{}.vs