Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support delete method in swagger generator #616

Merged
merged 2 commits into from
Apr 26, 2018

Conversation

beerose
Copy link
Contributor

@beerose beerose commented Apr 24, 2018

Solves #559 and generates query parameters for the delete method.

@tmc
Copy link
Collaborator

tmc commented Apr 24, 2018

Thanks for your contribution! The upstream issue appears fixed, can you rebase to trigger another build?

@beerose beerose force-pushed the feat/delete-method branch 6 times, most recently from 2ef4b04 to 128f7ef Compare April 24, 2018 22:15
@yugui
Copy link
Member

yugui commented Apr 25, 2018

https://travis-ci.org/grpc-ecosystem/grpc-gateway/jobs/370802179 (Go 1.10.x; GATEWAY_PLUGIN_FLAGS=) is failing due to the issue solved by #619.
https://travis-ci.org/grpc-ecosystem/grpc-gateway/jobs/370802182 (Go master; GATEWAY_PLUGIN_FLAGS=request_context=false) seems to be flaky. And now failing because of incompatibility to #618.

Would you mind rebasing the branch again?

@yugui
Copy link
Member

yugui commented Apr 25, 2018

Confirmed in https://travis-ci.org/grpc-ecosystem/grpc-gateway/builds/370873461. The branch is safe to merge.

I can merge this PR if it looks good to @achew22.

@codecov-io
Copy link

codecov-io commented Apr 25, 2018

Codecov Report

Merging #616 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #616   +/-   ##
=======================================
  Coverage   59.28%   59.28%           
=======================================
  Files          28       28           
  Lines        2780     2780           
=======================================
  Hits         1648     1648           
  Misses        971      971           
  Partials      161      161
Impacted Files Coverage Δ
protoc-gen-swagger/genswagger/template.go 42.35% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 739cd2d...437255e. Read the comment docs.

@beerose
Copy link
Contributor Author

beerose commented Apr 25, 2018

@yugui done 🙂

@achew22
Copy link
Collaborator

achew22 commented Apr 25, 2018

Can you change one of the proto files to exhibit this new behavior and run make examples?

@beerose beerose force-pushed the feat/delete-method branch 3 times, most recently from 90e1c41 to f21234d Compare April 25, 2018 16:10
@beerose
Copy link
Contributor Author

beerose commented Apr 25, 2018

I've added simple endpoint exhibiting the new behavior to the examples @achew22

@achew22
Copy link
Collaborator

achew22 commented Apr 26, 2018

@BlackDahila, I think this is good to go. Thanks so much for your contribution! I look forward to doing it again soon.

@achew22 achew22 merged commit 544e349 into grpc-ecosystem:master Apr 26, 2018
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants