Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple metadata annotators #586

Merged

Conversation

dmacthedestroyer
Copy link
Contributor

Modify the ServeMux struct so multiple runtime.WithMetadata options can be provided, and all their results combined into a single metadata object

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@dmacthedestroyer
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@achew22 achew22 merged commit 7a2a436 into grpc-ecosystem:master Apr 15, 2018
@achew22
Copy link
Collaborator

achew22 commented Apr 15, 2018

Thanks so much for your contribution!

@dmacthedestroyer dmacthedestroyer deleted the feature-multi-md-annotators branch April 16, 2018 16:18
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants