Stop marshalling any.Any types unnecessarily.

[johanbrandhorst]

Fixes #576.

[johanbrandhorst]

@achew22 this should be a harmless change, could you take a quick look please?

[achew22]

My understanding of the proto registry is unfortunately lacking WRT this topic. My expectation is that the proto on the wire wouldn't contain enough information to serialize it down to json. Does the any proto contain a field => name mapping in the wire format for it or something?

Could you also add a test to ensure this behavior doesn't regress?

[johanbrandhorst]

This changes just removes a no-op that was there from when this was first added, probably because the original implementation was confused as to whether this would be necessary or not. This kind of marshalling is already done in several other places:

grpc-gateway/runtime/proto_errors.go

Line 37 in 58f78b9

buf, merr := marshaler.Marshal(s.Proto())

grpc-gateway/runtime/handler.go

Line 178 in 58f78b9

grpcDetails = s.Proto().GetDetails()

I will look at adding some tests.

[johanbrandhorst]

Added a test for marshalling with details.

[tmc]

@johanbrandhorst thanks for this, can you rebase and resolve that test conflict?

[johanbrandhorst]

@tmc rebase completed!

[johanbrandhorst]

@tmc Is that test failure due to my change? It seems unrelated.

[tmc]

Sorry I missed your comment. The failure does appear to have been unrelated. Please resolve the conflicts here and let's get this in!

[johanbrandhorst]

Rebased :)

[johanbrandhorst]

Think I've hit a flaky test, could I have a rerun please? @tmc

[achew22]

Retriggered

[johanbrandhorst]

Looking good on my end, happy to merge?

[johanbrandhorst]

Not entirely sure why it's required me to regenerate the protofiles though 🤔

[tmc]

LGTM

[tmc]

To add ,proto3

[tmc]

@achew22 I'll let you complete review and merge

[achew22]

LGTM. Looks like there is a merge conflict. It isn't trivial to do from the web interface and I'm at work, but @tmc feel free to merge if you can get it to have no conflicts

[johanbrandhorst]

Curses! I'll fix it.

[johanbrandhorst]

Alright that should've done it. I had to pull and push over HTTPS as this airport WiFi must be blocking port 22 🤔.

[codecov-io]

Codecov Report

Merging #577 into master will increase coverage by 1.51%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
+ Coverage   56.43%   57.95%   +1.51%     
==========================================
  Files          30       30              
  Lines        3005     2918      -87     
==========================================
- Hits         1696     1691       -5     
+ Misses       1145     1064      -81     
+ Partials      164      163       -1

Impacted Files	Coverage Δ
runtime/errors.go	45.07% <100%> (+7.4%)	⬆️
runtime/marshal_json.go	66.66% <0%> (-16.67%)	⬇️
protoc-gen-swagger/genswagger/template.go	42.1% <0%> (+3.58%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b9677c...1665baf. Read the comment docs.