Omit well-known type definitions from swagger output #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexleigh Do you think you could add an example proto in |
|
@alexleigh, Looks great to me! Thanks so much for your contribution 😄. I look forward to working more with you in the future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #496 the swagger output was improved by adding support for more well-known types to the
wktSchemasmap. However, these types are not added to a parallel list of cases inrenderMessagesAsDefinition, causing the swagger output to contain type definitions for types that will never be emitted by the schema generator. This change fixes the issue by omitting these well-known types from the generated swagger schemas.