Memoise calls to fullyQualifiedNameToSwaggerName to speed it up for large registries #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterebden thank you for your contribution, have you signed the CLA? |
|
Yes I have - I can see it on cla.developers.google.com. |
|
@peterebden thanks, for whatever reason the cla bot needs a comment to kick in. |
tmc
reviewed
Jun 27, 2017
| // lastRegistry is used to remember the last registry passed into fullyQualifiedNameToSwaggerName; | ||
| // we use that to memoise calls to resolveFullyQualifiedNamesToSwaggerNames since it can be | ||
| // significantly slow for registries of hundreds of entries. | ||
| var lastRegistry *descriptor.Registry |
There was a problem hiding this comment.
can we instead do something like var fqmnCache = map[*descriptor.Registry]map[string]string so we can avoid the extra 'last' concept and just compute the cache once per registry seen?
There was a problem hiding this comment.
Sure, done. I did think about doing something like that at first but in the end got a little bit lazy with it :)
tmc
approved these changes
Jul 3, 2017
|
@peterebden ping |
|
I don't seem to be able to merge this - maybe cla-bot needs another message? |
|
Looks like the CLA bot is happy now. Merging (sorry for the delay) |
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
…arge registries (grpc-ecosystem#421) Memoise calls to fullyQualifiedNameToSwaggerName for all registries ever seen instead of just the last one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're observing some very slow compile times (on the order of ~1 minute) for reasonably large protos, containing hundreds of messages or so.
This implements a very simple cache of calls to determine Swagger names inside
fullyQualifiedNameToSwaggerNamewhich appears to be taking most of the time; after this change compilation time is well under 1 second.