Use go_package option if found. #417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! master has a build system fix, can you please rebase this? |
|
Closing this PR in favor of #462. |
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
Dec 5, 2017
Force the generated proto file to have a package name of _proto even though it lives in a folder with a different name. This is nessecary because all proto packages must end in _proto AND proto packages for APIs should live in a directory with their version number eg. "v1". This change requires an updated protoc-gen-grpc-gateway to respect the go_package declaration. grpc-ecosystem/grpc-gateway#417
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
Dec 5, 2017
Force the generated proto file to have a package name of _proto even though it lives in a folder with a different name. This is nessecary because all proto packages must end in _proto AND proto packages for APIs should live in a directory with their version number eg. "v1". This change requires an updated protoc-gen-grpc-gateway to respect the go_package declaration. grpc-ecosystem/grpc-gateway#417
gdbelvin
added a commit
to google/keytransparency
that referenced
this pull request
Dec 6, 2017
Force the generated proto file to have a package name of _proto even though it lives in a folder with a different name. This is nessecary because all proto packages must end in _proto AND proto packages for APIs should live in a directory with their version number eg. "v1". This change requires an updated protoc-gen-grpc-gateway to respect the go_package declaration. grpc-ecosystem/grpc-gateway#417
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
protoc-gen-grpc-gatewaydoes not respect thego_packageoption for output path.Check if a
go_packageoption was specified and use that as the base output path.