Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Swagger Codegen from 2.1.6 to 2.2.2 #415

Merged
merged 3 commits into from
Jun 23, 2017
Merged

Conversation

yugui
Copy link
Member

@yugui yugui commented Jun 17, 2017

No description provided.

Its file name convention looks to have been changed
@yugui yugui requested a review from achew22 June 19, 2017 03:47
@tmc tmc changed the title Update Swaggar Codegen from 2.1.6 to 2.2.2 Update Swagger Codegen from 2.1.6 to 2.2.2 Jun 20, 2017
package abe

// NumericEnum is one or zero. - ZERO: ZERO means 0 - ONE: ONE means 1
type ExamplepbNumericEnum struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why the enum values are empty?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why. But this PR is neutral to the issue.
https://github.com/grpc-ecosystem/grpc-gateway/pull/415/files#diff-743714d76d1753794032b45e364fd780

Can we work on the issue in another PR?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100%. Would you be willing to file a bug?

@achew22 achew22 merged commit a5c7982 into master Jun 23, 2017
@yugui yugui deleted the feature/update-swagger branch April 22, 2018 02:14
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants