Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return codes.InvalidArgument to rather return HTTP 400 instead of HTTP 500 #397

Closed
wants to merge 3 commits into from
Closed

Return codes.InvalidArgument to rather return HTTP 400 instead of HTTP 500 #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5538f7
Return InvalidArgument if param conversion fail
pieterlouw May 19, 2017
faf4782
Merge branch 'master' of https://github.com/grpc-ecosystem/grpc-gateway
pieterlouw May 19, 2017
fbcdb40
Return codes.InvalidArgument if parameter conversion failed
pieterlouw May 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion protoc-gen-grpc-gateway/gengateway/template.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ var (
{{$param.RHS "protoReq"}}, err = {{$param.ConvertFuncExpr}}(val)
{{end}}
if err != nil {
return nil, metadata, err
return nil, metadata, grpc.Errorf(codes.InvalidArgument, "invalid parameter %s : %v", {{$param | printf "%q"}}, err)
}
{{end}}
{{end}}
Expand Down
Binary file added protoc-gen-grpc-gateway/main
View file
Open in desktop
Binary file not shown.