Return response headers from grpc server #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamalsaha
changed the title
|
cc: @tmc |
|
I'd like to have this exercised under test. |
|
I opened #362 previously and this may fit within that definition. |
|
2+1 to having a test. @tmc, what do you think about merging to get it fixed and then having @tamalsaha do a followup? |
|
@achew22 I think that's acceptable. |
|
LGTM once CI approves, I think this better fits into #362 |
|
Thank you! |
tmc
pushed a commit
to tmc/grpc-gateway
that referenced
this pull request
May 12, 2017
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was introduced in #336.