Skip unreferenced messages in definitions. #371
Conversation
lantame
force-pushed
the
master
branch
2 times, most recently
from
6c20d8b
to
08627e5
Compare
|
@lantame thanks for your contribution. This looks like a good change. What do you think about adding a small test that verifies this behavior? Also, have you signed the CLA? |
|
Yes, I signed the CLA 8 hours ago. But somehow this check does not pass :-( |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
CLAs look good, thanks! |
|
Added a test. @tmc take a look pls. |
If all message fields are embedded in path + query args, the message itself is not referenced, so swagger generates warnings. Here we track request messages referenced in methods, and do not include unreferenced ones.
|
@lantame thanks! can you comment again to try to kick the cla bot into action? |
|
Hello CLA bot! |
This reverts commit b1e4aed.
* Skip unreferenced messages in definitions. If all message fields are embedded in path + query args, the message itself is not referenced, so swagger generates warnings. Here we track request messages referenced in methods, and do not include unreferenced ones. * Add a test.
If all message fields are embedded in path + query args,
the message itself is not referenced, so swagger generates
warnings.
Here we track request messages referenced in methods, and do not include
unreferenced ones.